Update Canceled task flow #24137

thienlnam · 2023-08-03T23:58:46Z

Details

Fixed Issues

$ #19504
PROPOSAL:

Tests

Create a task
Open the task
Cancel the task
Verify that the task report shows [Deleted Task] and that you can still comment and interact with the deleted task like a regular thread
Verify that in the parent report, the task shows [Deleted Task]

Offline tests

Same as online

QA Steps

Same as tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-11.at.4.59.41.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-11.at.5.00.45.PM.mov

Mobile Web - Safari

Screen.Recording.2023-09-11.at.5.05.53.PM.mov

Desktop

Screen.Recording.2023-09-11.at.5.10.29.PM.mov

iOS

Screen.Recording.2023-09-11.at.5.08.10.PM.mov

Android

melvin-bot · 2023-09-11T09:15:28Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2023-09-11T12:00:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

24137.Web.mov

Mobile Web - Chrome

24137.mWeb-Chrome.mp4

Mobile Web - Safari

24137.mWeb.Safari.mp4

Desktop

24137.Desktop.mov

iOS

24137.iOS.mp4

Android

24137.Android.mp4

mollfpr

I'm testing the PR now.

src/libs/ReportActionsUtils.js

mollfpr · 2023-09-11T14:48:22Z

This PR has a different result from the attached design.

Design	Current

There's no line below the parent action/deleted task
We are still showing the message of deleted task and the task title

Should we resolve the above note in this PR, or will it be fixed in another issue?

mollfpr · 2023-09-11T15:24:42Z

src/libs/ReportUtils.js

 * @returns {Boolean}
 */
-function isOpenTaskReport(report) {
-    return isTaskReport(report) && report.stateNum === CONST.REPORT.STATE_NUM.OPEN && report.statusNum === CONST.REPORT.STATUS.OPEN;
+function isCanceledTaskReport(report = {}, parentReportAction = {}) {


I don't think this method is specific only for task reports. I just tested deleting request money that has a message and thread; the actions also have isDeletedParentAction flagging.

Yeah you are correct, a couple different report types can have the isDeletedParentAction. Though I am planning on keeping this name as task reports are slightly different in that the report can have the isDeletedParentAction key as well

thienlnam · 2023-09-12T06:06:46Z

Thanks for the quick review!

There's no line below the parent action/deleted task

Fixed this!

We are still showing the message of deleted task and the task title

Yeah this is expected for now, there's a different issue that will handle updating the system messages

mollfpr · 2023-09-12T14:24:22Z

@thienlnam The task detail is not immediately removed after I navigate to the task detail report with the browser back button from a thread. The issue is easier to observe offline. Here's the step:

Go offline
Create a task and open the task detail
Send a message
Right-click on the message and select reply in a thread
Press the browser back button
Cancel the task

OFFLINE

Untitled.mov

ONLINE

Screen.Recording.2023-09-12.at.21.15.30.mov

thienlnam · 2023-09-15T03:53:16Z

The task detail is not immediately removed after I navigate to the task detail report with the browser back button from a thread. The issue is easier to observe offline.

Oh nice catch, I can create a follow up issue for this - hoping we get this main thing merged and then can do clean up later

mollfpr

melvin-bot · 2023-09-15T14:51:16Z

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2023-09-18T15:57:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

ayazhussain79 · 2023-09-18T16:35:49Z

Can we start testing canceled task flow?

thienlnam · 2023-09-19T01:46:39Z

@ayazhussain79 Yup! Feel free to start, we already created an issue for one known bug already here. But is ready to test now

ayazhussain79 · 2023-09-19T06:59:45Z

Ok Thank you

OSBotify · 2023-09-20T08:46:30Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-22T13:28:25Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nam-odele · 2023-09-29T11:42:19Z

@thienlnam after task deleted without any message on thread (except task action message) so in the parent report we still show [deleted message] or not.

thienlnam · 2023-09-30T09:14:49Z

@thienlnam after task deleted without any message on thread (except task action message) so in the parent report we still show [deleted message] or not.

This is how threads work so we should align with that (deleting entirely if there is no message in the task thread) - this may require some BE changes though

iwiznia · 2024-01-10T16:08:52Z

src/languages/es.ts

@@ -1542,7 +1542,7 @@ export default {
        completed: 'Completada',
        messages: {
            completed: 'tarea completada',
-            canceled: 'tarea cancelada',
+            canceled: 'tarea eliminado',


@thienlnam I don't know where you got this translation from (I checked slack and could not find it anywhere), but it is wrong. Please make sure you always get confirmation in #espanol-tranlsations

Sending a PR to fix this

alitoshmatov · 2024-07-26T10:45:06Z

src/libs/actions/Task.js

+
+    const optimisticReportActions = {
+        [parentReportAction.reportActionID]: {
+            pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,


Pending action here could be either update or delete based on if it has thread messages, ref: #44997

thienlnam added 18 commits July 31, 2023 09:24

Add parent reportAction isDeletedParentAction

b862234

Merge branch 'main' into jack-updateCancelledTaskUI

fffb864

Add isDeletedParentAction check

69b6784

Update header view on cancelled task

f40a5ac

update the header

2626fa9

add method to get all reportActions

1c887da

Merge branch 'main' into jack-updateCancelledTaskUI

b765ae3

update cancelTask method

c9df9ce

Merge branch 'main' into jack-updateCancelledTaskUI

f175265

fix message not showing up

f640ac2

show the parent

24fc6c8

Merge branch 'main' into jack-updateCancelledTaskUI

26858ed

Remove the link in Preview isDeletedParentAction

7998e95

Update method that checks isCanceledTaskReport

1c9ee15

Update places we check isCancelled task report

0665968

Update places isCanceledTaskReport

b7ba6e9

onyx updates

7ea0e80

pass the actual report

84d289b

thienlnam self-assigned this Aug 3, 2023

thienlnam added 3 commits August 10, 2023 16:30

Merge branch 'main' into jack-updateCancelledTaskUI

32d5f1f

Make sure we don't include cancelled tasks in the selector

e5c898a

Merge branch 'main' into jack-updateCancelledTaskUI

52ea600

thienlnam mentioned this pull request Aug 16, 2023

[HOLD for payment 2023-09-29] [$1000] Show different UI for a cancelled task #19504

Closed

thienlnam added 3 commits August 16, 2023 13:11

Merge branch 'main' into jack-updateCancelledTaskUI

1796bc8

Merge branch 'main' into jack-updateCancelledTaskUI

206669d

Add RenderHTML to show deleted reportAction

61bc6ae

aldo-expensify mentioned this pull request Aug 21, 2023

[HOLD https://github.com/Expensify/App/pull/24137] Assign task - We are able to open archived chat's description via deeplink #24661

Closed

6 tasks

thienlnam added 3 commits August 30, 2023 11:34

Merge branch 'main' into jack-updateCancelledTaskUI

ec7ea0f

Move around Cancel Task check

1d0064e

Clean up items related to new openTask check

52b3f9c

melvin-bot bot requested a review from mollfpr September 11, 2023 09:15

mollfpr reviewed Sep 11, 2023

View reviewed changes

src/libs/ReportActionsUtils.js Outdated Show resolved Hide resolved

mollfpr reviewed Sep 11, 2023

View reviewed changes

Add horizontal rule

e80fd05

Merge branch 'main' into jack-updateCancelledTaskUI

b4604fb

mollfpr approved these changes Sep 15, 2023

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski September 15, 2023 14:51

tylerkaraszewski approved these changes Sep 18, 2023

View reviewed changes

tylerkaraszewski merged commit 949a7d7 into main Sep 18, 2023
12 checks passed

tylerkaraszewski deleted the jack-updateCancelledTaskUI branch September 18, 2023 15:51

thienlnam mentioned this pull request Sep 19, 2023

[$500] Task details are not immediately removed after navigating back to a task using the back button browser #27728

Closed

OSBotify mentioned this pull request Sep 20, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

iwiznia reviewed Jan 10, 2024

View reviewed changes

alitoshmatov reviewed Jul 26, 2024

View reviewed changes

alitoshmatov mentioned this pull request Jul 26, 2024

[HOLD for payment 2024-07-26] [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page #44997

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Canceled task flow #24137

Update Canceled task flow #24137

thienlnam commented Aug 3, 2023 •

edited

Loading

melvin-bot bot commented Sep 11, 2023

mollfpr commented Sep 11, 2023 •

edited

Loading

mollfpr left a comment

mollfpr commented Sep 11, 2023

mollfpr Sep 11, 2023

thienlnam Sep 12, 2023

thienlnam commented Sep 12, 2023

mollfpr commented Sep 12, 2023

thienlnam commented Sep 15, 2023 •

edited

Loading

mollfpr left a comment

melvin-bot bot commented Sep 15, 2023

OSBotify commented Sep 18, 2023

ayazhussain79 commented Sep 18, 2023

thienlnam commented Sep 19, 2023

ayazhussain79 commented Sep 19, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

nam-odele commented Sep 29, 2023

thienlnam commented Sep 30, 2023 •

edited

Loading

iwiznia Jan 10, 2024

iwiznia Jan 10, 2024

alitoshmatov Jul 26, 2024 •

edited

Loading

Update Canceled task flow #24137

Update Canceled task flow #24137

Conversation

thienlnam commented Aug 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 11, 2023

mollfpr commented Sep 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr commented Sep 11, 2023

mollfpr Sep 11, 2023

Choose a reason for hiding this comment

thienlnam Sep 12, 2023

Choose a reason for hiding this comment

thienlnam commented Sep 12, 2023

mollfpr commented Sep 12, 2023

thienlnam commented Sep 15, 2023 • edited Loading

mollfpr left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 15, 2023

OSBotify commented Sep 18, 2023

ayazhussain79 commented Sep 18, 2023

thienlnam commented Sep 19, 2023

ayazhussain79 commented Sep 19, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

nam-odele commented Sep 29, 2023

thienlnam commented Sep 30, 2023 • edited Loading

iwiznia Jan 10, 2024

Choose a reason for hiding this comment

iwiznia Jan 10, 2024

Choose a reason for hiding this comment

alitoshmatov Jul 26, 2024 • edited Loading

Choose a reason for hiding this comment

thienlnam commented Aug 3, 2023 •

edited

Loading

mollfpr commented Sep 11, 2023 •

edited

Loading

thienlnam commented Sep 15, 2023 •

edited

Loading

thienlnam commented Sep 30, 2023 •

edited

Loading

alitoshmatov Jul 26, 2024 •

edited

Loading